Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

给语言选择加一个大而美的边框 #16

Merged
merged 4 commits into from
Feb 19, 2024
Merged

给语言选择加一个大而美的边框 #16

merged 4 commits into from
Feb 19, 2024

Conversation

ddzzkunye
Copy link
Contributor

给语言选择加一个大而美的边框

@ddzzkunye
Update translations.scss
dca6774 
给语言选择加了一个更大的边框

Signed-off-by: 前进! <[email protected]>
@saeziae
Copy link
Member

saeziae commented Feb 18, 2024 •
edited
Loading

recommendation: use abbreviation for language names to make this button narrower then it could be BIGGER.
like use EN for english and DE for german, and use 簡 繁 日 for zh-Hans zh-Hant ja.

@Cryolitia
Copy link
Member

要不要来 Project Trans develop 组干活，我们现在正好缺苦力（打个广告

@ddzzkunye
Copy link
Contributor Author

效果预览

image

开启自动深色模式
image

@ddzzkunye ddzzkunye marked this pull request as ready for review February 18, 2024 12:07
@ddzzkunye ddzzkunye requested a review from septs as a code owner February 18, 2024 12:07
@ddzzkunye ddzzkunye marked this pull request as draft February 18, 2024 12:16
@ddzzkunye
Copy link
Contributor Author

我好菜啊/_ \

@ddzzkunye ddzzkunye marked this pull request as ready for review February 19, 2024 08:46
@ddzzkunye
Copy link
Contributor Author

清理注释修复bug, 顺便搞一手注释i18n.
下面两张预览图
预览图
预览图,开启自动深色

@ddzzkunye
Copy link
Contributor Author

ddzzkunye commented Feb 19, 2024 •
edited
Loading

pr先开在这里, 视情况考虑要不要加吧
#15

@saeziae saeziae enabled auto-merge (squash) February 19, 2024 09:32
saeziae
saeziae approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@saeziae saeziae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

关于按钮上使用缩写，另外再实现。

Cryolitia
Cryolitia approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saeziae saeziae merged commit 1974be0 into project-trans:main Feb 19, 2024
@ddzzkunye ddzzkunye deleted the patch-1 branch February 20, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww left review comments

@saeziae saeziae saeziae approved these changes

@Cryolitia Cryolitia Cryolitia approved these changes

@septs septs septs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ddzzkunye @saeziae @Cryolitia @septs @nekomeowww