Skip to content

Commit

Permalink
test: avoid dockerhub dependency
Browse files Browse the repository at this point in the history
two tests had bare image names, causing problems with dockerhub rate
limiting. move instead to AWS

also clarifies a skip message which was a little confusing because most
of the test is actually completed.

Signed-off-by: Michael McCracken <[email protected]>
  • Loading branch information
mikemccracken committed Jan 14, 2025
1 parent 2dafa06 commit 2eab97f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions test/convert.bats
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function teardown() {

@test "convert a Dockerfile" {
cat > Dockerfile <<EOF
FROM alpine:3.16
FROM public.ecr.aws/docker/library/alpine:edge
VOLUME /out
ARG VERSION=1.0.0
MAINTAINER unknown
Expand Down Expand Up @@ -40,7 +40,7 @@ EOF
mkdir -p /out
stacker build -f stacker.yaml --substitute-file stacker-subs.yaml --substitute IMAGE=app
if [ -z "${REGISTRY_URL}" ]; then
skip "test because no registry found in REGISTRY_URL env variable"
skip "publish step of test because no registry found in REGISTRY_URL env variable"
fi
stacker publish -f stacker.yaml --substitute-file stacker-subs.yaml --substitute IMAGE=app --skip-tls --url docker://${REGISTRY_URL} --image app --tag latest
rm -f stacker.yaml stacker-subs.yaml
Expand Down
2 changes: 1 addition & 1 deletion test/whiteout.bats
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ EOF
bb:
from:
type: docker
url: docker://busybox
url: docker://public.ecr.aws/docker/library/busybox:latest
run: |
mkdir /a1
touch /a1/file
Expand Down

0 comments on commit 2eab97f

Please sign in to comment.