feat: initial commit for erofs support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
force-pushed
the
ero
branch
5 times, most recently
from
d0480ec to
4f4ab76
Compare
|
^ have a stacker PR that builds against this PR. |
rchincha
requested review from
mikemccracken,
rchamarthy,
hallyn,
raharper and
ariel-miculas
raharper
requested changes
Nov 11, 2024
Just one bats test is failing |
rchincha
force-pushed
the
ero
branch
3 times, most recently
from
1b6bc44 to
5940164
Compare
|
Thanks for the update. I think I'm still missing something. I see |
raharper
reviewed
Nov 13, 2024
pkg/erofs/erofs.go
Outdated
Comment on lines
76
to
80
| tmpErofs.Close() | ||
| os.Remove(tmpErofs.Name()) | ||
| defer os.Remove(tmpErofs.Name()) | ||
| args := []string{tmpErofs.Name(), rootfs} | ||
| compression := GzipCompression |
There was a problem hiding this comment.
This probably should be parameter right?
rchincha
force-pushed
the
ero
branch
2 times, most recently
from
fb69535 to
3541b62
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 15.68% 13.85% -1.84%
==========================================
Files 7 16 +9
Lines 1358 1718 +360
==========================================
+ Hits 213 238 +25
- Misses 1117 1440 +323
- Partials 28 40 +12 ☔ View full report in Codecov by Sentry. |
rchincha
force-pushed
the
ero
branch
6 times, most recently
from
88dfd93 to
9dc7dfd
Compare
rchincha
force-pushed
the
ero
branch
10 times, most recently
from
97e2b40 to
15cdcb2
Compare
|
https://lore.kernel.org/all/[email protected]/T/ |
|
Going to deprecate the double + and just rely on the root_hash annotation for verity |
raharper
reviewed
Nov 25, 2024
rchincha
force-pushed
the
ero
branch
8 times, most recently
from
8e5f19b to
8ab7e49
Compare
|
Just tested build erofs image, atomfs mount and then lxc-execute. Works nicely! |
Before this commit, only squashfs was supported. However, there are other filesystems such as erofs that fit the same theme, and additional filesystem support requires refactoring and exposing a more generic filesystem interface. pkg/fs/fs.go - Filesystem interface pkg/squashfs - squashfs pkg/erofs - erofs pkg/common - filesystem-agnostic common routines pkg/verity - verity routines Signed-off-by: Ramkumar Chinchani <[email protected]>
Signed-off-by: Ramkumar Chinchani <[email protected]>
BREAKING-CHANGE: the layer media-type no longer contains "+verity" For a layer media-type, we add the fstype+compression+verity_present. Only one '+' is allowed as per following RFC. https://datatracker.ietf.org/doc/html/rfc6838#section-4.2 Instead just rely on "root_hash" annotation. Signed-off-by: Ramkumar Chinchani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt, converging faster.
pkg/fs <- main interface .. everything calls into here, stacker, atomfs, atomfs-snapshotter
pkg/squashfs
pkg/erofs
pkg/common <- common fs routines .. should probably become "internal"
pkg/verity <- verity stuff
pkg/molecule
pkg/log
pkg/mount