-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5551] prep for AWS Glue Data Catalogue migration #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5449 +/- ##
=======================================
- Coverage 94.2% 94.1% -0.0%
=======================================
Files 370 370
Lines 31539 31550 +11
Branches 3378 3381 +3
=======================================
+ Hits 29702 29703 +1
- Misses 1195 1199 +4
- Partials 642 648 +6 |
maskarb
changed the title
[COST-5368] prep for AWS Glue Data Catalogue migration
[COST-5551] prep for AWS Glue Data Catalogue migration
Jan 16, 2025
maskarb
added
full-run-smoke-tests
pr_check will build the image and run all smoke tests
and removed
smoke-tests
pr_check will build the image and run minimal required smokes
labels
Jan 22, 2025
lcouzens
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5551
Description
This change will do a few things:
schema_name
toschema
(for the sake of consistency)trino_schema_prefix
to all sql files and sql_params where necessaryTRINO_SCHEMA_PREFIX
env variable -> defaults to empty initiallyTRINO_S3A_OR_S3
env variable -> defaults tos3a
initially (what it currently is today)SCHEMA_SUFFIX
env variable -> currently unused, but will be used after we switch to Glue for local and ephemeralTesting
hive:
transition to Glue from Hive:
POSTGRES_SQL_SERVICE_HOST
,POSTGRES_SQL_SERVICE_PORT
,DATABASE_USER
, andDATABASE_PASSWORD
to connect to RDSCREATE DATABASE db_name ;
); updateDATABASE_NAME
env variableSCHEMA_SUFFIX=_username
; setTRINO_S3A_OR_S3=s3a
; setTRINO_SCHEMA_PREFIX=""
$ make create-test-customer; make load-test-customer-data test_source=AWS
and allow the data to ingestTRINO_S3A_OR_S3=s3
; setTRINO_SCHEMA_PREFIX="hccm_"
glue.properties
files tohive.properties
in the trino container and remove the dependency of hive-metastore.make load-test-customer-data test_source=GCP
Release Notes