-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5851] one expiration task per provider_type #5432
Merged
Merged
+72
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 2, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5432 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 371 371
Lines 31631 31635 +4
Branches 3386 3389 +3
=======================================
+ Hits 29770 29773 +3
Misses 1211 1211
- Partials 650 651 +1 |
/retest |
maskarb
changed the title
one expiration task per provider type
[COST-5851] one expiration task per provider_type
Jan 27, 2025
/retest |
djnakabaale
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, one small nitpick:
djnakabaale
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5851
Description
This change will:
cascade_delete
to remove the expiredOCPUsageReportPeriod
instead of the Django delete methodTesting
http://localhost:8000/api/cost-management/v1/reports/aws/costs/?filter[time_scope_value]=-30
(see data for 2 months)
RETAIN_NUM_MONTHS=1
and restart koku-worker(set the
REDIS_HOST
so that the shell can reach Redis)Orchestrator
to trigger a deletion:See that each provider-type only appears once in the result list AND OCP is called last.
http://localhost:8000/api/cost-management/v1/reports/aws/costs/?filter[time_scope_value]=-30
Release Notes