[js] Does not hide time range window when select date and time #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
approved these changes
May 15, 2017
masa0612
reviewed
May 15, 2017
client/static/js/events_view.js
Outdated
| @@ -959,7 +959,8 @@ var EventsView = function(userProfile, options) { | |||
| function setupTimeRangeFilter() { | |||
| $('#begin-time').datetimepicker({ | |||
| format: 'Y/m/d H:i:s', | |||
| closeOnDateSelect: true, | |||
| closeOnDateSelect: false, | |||
| closeOnDateSelect: false, | |||
There was a problem hiding this comment.
自分のコミットで大変申し訳無いんだけど，ここ同じコード2連続で書いていて間違ってます。
正確にはtirgger_view.jsにあるように，closeOnDateSelectとcloseOnTimeSelectです。
client/static/js/events_view.js
Outdated
| @@ -970,7 +971,8 @@ var EventsView = function(userProfile, options) { | |||
|
|
|||
| $('#end-time').datetimepicker({ | |||
| format: 'Y/m/d H:i:s', | |||
| closeOnDateSelect: true, | |||
| closeOnDateSelect: false, | |||
| closeOnDateSelect: false, | |||
otakuto
force-pushed
the
oss/does-not-hide-when-click
branch
from
7dcf03b to
7703f2b
Compare
|
修正しました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2523 時間，日付を選択してもウィンドウが閉じないようにした。