-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adicionado suporte ao r2 #1151
base: master
Are you sure you want to change the base?
Conversation
I am waiting the approval. |
Hey @HugoSilvaF ! Awesome PR! I'll have a look! Would be great if you could also update the docs with this guide! |
accessKeyId: config.images.r2.credentials.accessKeyId, | ||
secretAccessKey: config.images.r2.credentials.secretAccessKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be in the config. We should get these from Convars not exposed to client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
"dependencies": { | ||
"@aws-sdk/client-s3": "^3.574.0", | ||
"aws-sdk": "^2.1618.0" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please install these the correct package.json file. We are using turborepo, so you can install these deps in the game package like this
pnpm --filter @npwd/game add ....
from the root dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Pull Request Description
I changed config.json, ResourceConfig interface, http-service.
I have added supports to Cloudflare R2 to upload images.
IMGUR doesnt works anymore, so i have added another option.
To r2 works, need the public link in
In url needs the public url the r2
your config
you need access cloudflare and create an account and a public r2 bucket
https://dash.cloudflare.com/
after created your account you need go to the r2 overiew
after this, you need create an bucket
after created your bucket go to the settings and get a public url
getting a public url
Pull Request Checklist: