Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release/build): update node version to 20.x #80

Merged
merged 1 commit into from
May 7, 2024

Conversation

r3ps4J
Copy link
Contributor

@r3ps4J r3ps4J commented May 6, 2024

Pull Request Description

Hi! The current workflows are broken since node 14 has reached end of life and is no longer supported by the majority of packages. I ran into this error from @typescript-eslint/eslint-plugin, but I'm pretty sure most other packages (if not all) used in this template no longer support it either. In this pull request I simply updated the node version in the workflows to the latest LTS version, which is 20 at the time of writing.

Pull Request Checklist:

  • Have you followed the guidelines in our contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open for the same update/change?
  • Have you built and tested the resource in-game after the relevant change?

Last one is not applicable due to this being a change to the CI workflows.

@itschip
Copy link
Member

itschip commented May 7, 2024

Hey! Thank you for the contribution! LGTM

@itschip itschip merged commit 105f5f7 into project-error:master May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants