controller/python: add device attestation revocation support #37134
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the required changes in the python binding. Added the cli option to matter testing framework for setting the dac revocation set path.
|
Review changes with Changed Files
|
|
PR #37134: Size comparison from e6e9614 to df97121 Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37134: Size comparison from e6e9614 to 5cf1981 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jan 22, 2025
| @@ -2018,7 +2018,7 @@ class ChipDeviceController(ChipDeviceControllerBase): | |||
| ''' | |||
|
|
|||
| def __init__(self, opCredsContext: ctypes.c_void_p, fabricId: int, nodeId: int, adminVendorId: int, catTags: typing.List[int] = [ | |||
| ], paaTrustStorePath: str = "", useTestCommissioner: bool = False, fabricAdmin: typing.Optional[FabricAdmin.FabricAdmin] = None, name: str = '', keypair: typing.Optional[p256keypair.P256Keypair] = None): | |||
| ], paaTrustStorePath: str = "", dacRevocationSetPath: str = "", useTestCommissioner: bool = False, fabricAdmin: typing.Optional[FabricAdmin.FabricAdmin] = None, name: str = '', keypair: typing.Optional[p256keypair.P256Keypair] = None): | |||
There was a problem hiding this comment.
would you mind moving this to the end of the arguments list so it doesn't break anyone if they were using ordered arguments?
tehampson
approved these changes
Jan 22, 2025
| @@ -2018,7 +2018,7 @@ class ChipDeviceController(ChipDeviceControllerBase): | |||
| ''' | |||
|
|
|||
| def __init__(self, opCredsContext: ctypes.c_void_p, fabricId: int, nodeId: int, adminVendorId: int, catTags: typing.List[int] = [ | |||
| ], paaTrustStorePath: str = "", useTestCommissioner: bool = False, fabricAdmin: typing.Optional[FabricAdmin.FabricAdmin] = None, name: str = '', keypair: typing.Optional[p256keypair.P256Keypair] = None): | |||
| ], paaTrustStorePath: str = "", dacRevocationSetPath: str = "", useTestCommissioner: bool = False, fabricAdmin: typing.Optional[FabricAdmin.FabricAdmin] = None, name: str = '', keypair: typing.Optional[p256keypair.P256Keypair] = None): | |||
| super().__init__( | |||
There was a problem hiding this comment.
My approval is with the assumption:
- Ordering comment above it addressed
- controller/python: add device attestation revocation support #37134 lands first so people can replicate your test
| const char * paaTrustStorePath, bool useTestCommissioner, | ||
| bool enableServerInteractions, CASEAuthTag * caseAuthTags, uint32_t caseAuthTagLen, | ||
| chip::python::pychip_P256Keypair * operationalKey) | ||
| const char * paaTrustStorePath, const char * dacRevocationSetPath, |
There was a problem hiding this comment.
Please do not add this argument and let's configure the commissioner instance separately
Comment on lines
+505
to
+506
| chip::Credentials::DeviceAttestationRevocationDelegate * dacRevocationDelegate = | ||
| GetAttestationRevocationDelegate(dacRevocationSetPath); |
There was a problem hiding this comment.
This is what should be moved to a new API in ChipDeviceController
| chip::Credentials::DeviceAttestationRevocationDelegate * dacRevocationDelegate = | ||
| GetAttestationRevocationDelegate(dacRevocationSetPath); | ||
| chip::Credentials::DeviceAttestationVerifier * dacVerifier = | ||
| chip::Credentials::GetDefaultDACVerifier(testingRootStore, dacRevocationDelegate); |
There was a problem hiding this comment.
Now I see that coupling the DAC revocation delegate to the default DAC verifier is what causes you to have to do this. It should still be possible to UPDATE the config of the DefaultDACVerifier, without needing to initially provide an instance of DAC revocation delegate. Suggest passing nullptr here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
NOTE: Used the
dac-provider-test-vectorsfrom #37122