Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated types in tests #1993

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix outdated types in tests #1993

merged 1 commit into from
Aug 5, 2024

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Aug 5, 2024

Fix #1992

@jubalh jubalh self-assigned this Aug 5, 2024
@jubalh jubalh added the cleanup label Aug 5, 2024
@jubalh jubalh added this to the next milestone Aug 5, 2024
@jubalh jubalh mentioned this pull request Aug 5, 2024
Closed
eli-schwartz
eli-schwartz approved these changes Aug 5, 2024
View reviewed changes
Copy link

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, fixes the report for me.

@jubalh jubalh merged commit 3b19a6a into master Aug 5, 2024
5 checks passed
@jubalh jubalh deleted the fix/1992-typemismatch branch August 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz approved these changes

Assignees

@jubalh jubalh

Labels
cleanup
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Tests fail with LTO due to type mismatch in unittest
2 participants
@jubalh @eli-schwartz