Introduce /redraw command
#1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H3rnand3zzz
force-pushed
the
feature/redraw-command
branch
from
b1226c1 to
98475c4
Compare
jubalh
reviewed
Nov 14, 2023
src/command/cmd_defs.c
Outdated
| CMD_SYN( | ||
| "/redraw") | ||
| CMD_DESC( | ||
| "Redraw User Interface. Might be used in case if some other program interrupted and interface is \"broken\"." ) |
There was a problem hiding this comment.
I'm not sure in case if is correct. I think the if can be canceled. Personally I probably would just use the first sentence.
There was a problem hiding this comment.
I also believe User and Interface should be lower case.
There was a problem hiding this comment.
Suggested change
| "Redraw User Interface. Might be used in case if some other program interrupted and interface is \"broken\"." ) | |
| "Redraw user interface. Can be used when some other program interrupted profanity or wrote to the same terminal and the interface looks \"broken\"." ) |
I also would just use the first sentence, but that's because I'm lazy :)
Here we're writing the help text for our users, which also shows up in the man pages, and I like the idea to include the "why" some command exists.
jubalh
requested changes
Nov 14, 2023
|
I think some users use a keybinding for their terminal. But probably a command can be helpful. |
sjaeckel
approved these changes
Nov 14, 2023
`/redraw` command allows resolve problem for usual users, as well as developers. Incredibly useful when debugging with something that can trash out the output, like GDB. Not to mention many asynchronous commands that can break the UI at any point.
H3rnand3zzz
force-pushed
the
feature/redraw-command
branch
from
98475c4 to
a1ff88c
Compare
|
updated |
jubalh
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.