Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth scrolling support (+mouse wheel scrolling in some terminals) #1824

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Smooth scrolling support (+mouse wheel scrolling in some terminals) #1824

merged 1 commit into from
Dec 5, 2023

Conversation

H3rnand3zzz
Copy link
Contributor

@H3rnand3zzz H3rnand3zzz commented Apr 13, 2023 •
edited
Loading

Added mouse scroll support with shift+scroll using readline.

Points before release:

  • Mouse compatibility
  • @sjaeckel's suggestions
  • Infinite scroll support

Known Issues: Sometimes it gets incredibly laggy (probably have something to do with profanity core)

@jubalh jubalh added the feature label Apr 13, 2023
@jubalh jubalh added this to the next milestone Apr 13, 2023
sjaeckel
sjaeckel reviewed Apr 13, 2023
View reviewed changes
src/ui/inputwin.c Outdated Show resolved Hide resolved
src/ui/inputwin.c Outdated Show resolved Hide resolved
@H3rnand3zzz H3rnand3zzz force-pushed the feature/mouse-scroll branch 3 times, most recently from 548afdf to a12ed1a Compare April 18, 2023 21:48
@H3rnand3zzz H3rnand3zzz marked this pull request as ready for review April 18, 2023 21:55
@H3rnand3zzz
Copy link
Contributor Author

It's ready for review, but not ready for release. I would appreciate advises on lag issue. Probably core-related. Even without binding, mouse scrolling makes considerable lag.

@H3rnand3zzz H3rnand3zzz requested a review from sjaeckel April 19, 2023 13:44
jubalh
jubalh requested changes Apr 19, 2023
View reviewed changes
src/ui/inputwin.c Outdated Show resolved Hide resolved
src/command/cmd_defs.c Outdated Show resolved Hide resolved
@jubalh
Copy link
Member

jubalh commented Apr 19, 2023

Again clang-format 😢
I assume you run 16.0.1 now, like me? So even between 16 and this something changed?
Let's check first whether for this situation we actually forgot to define a setting in the config file.

@H3rnand3zzz H3rnand3zzz force-pushed the feature/mouse-scroll branch 2 times, most recently from 8f3a424 to 96efcc4 Compare April 19, 2023 20:21
sjaeckel
sjaeckel requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again clean and easy to follow.

I'd like to have a second look tomorrow after those proposed changes are included.

src/command/cmd_defs.c Outdated Show resolved Hide resolved
src/ui/inputwin.c Outdated Show resolved Hide resolved
@H3rnand3zzz H3rnand3zzz force-pushed the feature/mouse-scroll branch from 96efcc4 to 8a9be46 Compare May 4, 2023 17:49
@H3rnand3zzz
Copy link
Contributor Author

To make it clear

At the current stage, the commit is incompatible with mouse and works only with touch pad. I hope to resolve it as soon as possible.

@H3rnand3zzz H3rnand3zzz marked this pull request as draft May 4, 2023 18:03
@jubalh jubalh removed this from the next milestone Jul 3, 2023
@H3rnand3zzz H3rnand3zzz force-pushed the feature/mouse-scroll branch 2 times, most recently from 53202df to 1714094 Compare November 13, 2023 10:59
@H3rnand3zzz H3rnand3zzz mentioned this pull request Nov 13, 2023
Merged
@H3rnand3zzz H3rnand3zzz marked this pull request as ready for review November 13, 2023 11:40
@H3rnand3zzz
Copy link
Contributor Author

Rebased on master
Followed by changing for alt+up/down instead of shift+up/down. Alt it more intuitive (since it presumes ALTernative behaviour for the same button) and minor changes to merge with previous updates.

@jubalh jubalh added this to the next milestone Nov 20, 2023
@H3rnand3zzz
Copy link
Contributor Author

@sjaeckel, is PR ok now?

@sjaeckel
Copy link
Member

I'll have a look soon, currently only on mobile

@H3rnand3zzz
Add ALT+UP/DOWN/mouse wheel scroll support
23692fe 
Before the change, the only way to scroll was usage of page up/down,
it allowed to scroll only by skipping pages, which was not smooth.
@H3rnand3zzz
Copy link
Contributor Author

New revision

  • Changes requested by @sjaeckel are implemented:
    • Removed preference (since alt+arrows support for navigation does not need to be optional)
    • Details are added in command description regarding other terminals' support

@H3rnand3zzz H3rnand3zzz changed the title Mouse scroll Smooth scrolling support Nov 28, 2023
@H3rnand3zzz H3rnand3zzz changed the title Smooth scrolling support Smooth scrolling support (+mouse wheel scrolling in some terminals) Nov 28, 2023
@jubalh jubalh merged commit bd0aa3e into profanity-im:master Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubalh jubalh jubalh approved these changes

@sjaeckel sjaeckel sjaeckel approved these changes

Assignees

@H3rnand3zzz H3rnand3zzz

Labels
feature
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
3 participants
@H3rnand3zzz @jubalh @sjaeckel