Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties to data model Source #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

development-motoin
Copy link
Contributor

@development-motoin development-motoin commented Oct 16, 2024

Both GET sites/<siteId>/sources and GET sites/<siteId>/streams provide some data fields in their response within key sources ( (see PlatformAPI-Documentation). Some of them are not supported by this lib so far.

Missing fields so far:

  • description
  • import_id
  • status
  • settings

Supported fields right now:

  • id
  • site_id
  • source
  • import_type

This PR add support of the missing fields mentioned above. In our webshop, we particularly need access to the settings field, as it lists the streams linked to a site, among other things. We don't want to hardcode this settings in our project, but rather use the current settings fetched from Platform-API.

@development-motoin development-motoin requested a review from a team as a code owner October 16, 2024 09:30
@development-motoin development-motoin requested review from takeit, plehatron, pupbot and m038-pup and removed request for a team October 16, 2024 09:30
@medbak medbak requested review from a team and medbak and removed request for a team October 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant