Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce StyleByNamePlugin #281

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 2, 2024

Provide the same API as StyleRegistry but pass names instead of ids to identify BPMN elements.

NOTE: To map names to ids, the plugin uses BpmnElementsSearcher.
The mapping is currently not cached, nor pre-fetched after the BPMN source has been loaded.
So the implementation is not very effective. Caching and pre-fetch features will be implemented in
the future.

Notes

Closes #75
There is no demo of this plugin for now, it will be done as part of #78.

Provide the same API as `StyleRegistry` but pass names instead of ids to identify BPMN elements.

NOTE: To map names to ids, the plugin uses `BpmnElementsSearcher`.
The mapping is currently not cached, nor pre-fetched after the BPMN source has been loaded.
So the implementation is not very effective. Caching and pre-fetch features will be implemented in
the future.
@tbouffard tbouffard added the enhancement New feature or request label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

🎊 PR Preview 58d74cf has been successfully built and deployed to https://process-analytics-bv-experimental-add-ons-demo-pr-281.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Copy link

sonarcloud bot commented Sep 3, 2024

@tbouffard tbouffard marked this pull request as ready for review September 3, 2024 06:45
@tbouffard tbouffard merged commit 84d9989 into main Sep 3, 2024
3 checks passed
@tbouffard tbouffard deleted the feat/GH-75_plugin_style-by-name branch September 3, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Introduce a plugin to expose the bpmn-visualization "style API" with names as parameters
1 participant