(WIP) Add ExtendingTraceTranslator. #370
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #313 by adding a more flexible variant of
SimpleExtendingTraceTranslator
:ExtendingTraceTranslator
accepts a bijective trace transform that remaps the choices sampled by the forward proposal distribution, before merging those choices into the extended model viaupdate
.Before I move forward with adding documentation and test cases, I'm wondering if perhaps this should just replace the existing
SimpleExtendingTraceTranslator
? This does everything thatSimpleExtendingTraceTranslator
does, and I don't think it adds much of a performance overhead to have theif-else
clause inExtendingTraceTranslator
that checks whether a trace transform needs to be applied. For backwards compatibility, I could even makeSimpleExtendingTraceTranslator
a constructor alias for anExtendingTraceTranslator
with the bijection filled in withnothing
.