Infer loader from filetype #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friewerts
reviewed
Jan 10, 2020
| "scripts": { | ||
| "test": "echo \"Error: run tests from root\" && exit 1" | ||
| }, | ||
| "scripts": {}, |
There was a problem hiding this comment.
i think this key can be removed
| @@ -0,0 +1,13 @@ | |||
| // babel.config.js | |||
There was a problem hiding this comment.
i think all the jest-related stuff should be located in the root dir, to be later extended by the packages
| @@ -0,0 +1,187 @@ | |||
| // For a detailed explanation regarding each configuration property, visit: | |||
There was a problem hiding this comment.
i think all the jest-related stuff should be located in the root dir, to be later extended by the packages
There was a problem hiding this comment.
Moved the jest-config to root
| @@ -66,5 +65,11 @@ | |||
| "style-loader": "1.0.1", | |||
| "webpack": "4.41.2", | |||
| "webpack-merge": "4.2.2" | |||
| }, | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
i think all the jest-related stuff should be located in the root dir, to be later extended by the packages
packages/webpack-config/src/helpers/getFileExtension/getFileExtension.js
Show resolved
Hide resolved
| @@ -0,0 +1,42 @@ | |||
| import getFileExtension from "./getFileExtension"; | |||
There was a problem hiding this comment.
the mentioned edge-cases could also be part of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Description ==
The pv.config.js should be as minimal as possible. To accomplish that we can infer some config values from the filetype. For example if the user configures the jsEntry to be "src/index.tsx" we can automatically set "useTS" and "useReact" to be true.
== Closes issue(s) ==
#39
== Changes ==
paths.js => config will be piped through the inferLoaderFromFiletype function.
== Affected Packages ==
webpack-config