fix(pv-stylemark): fix regex extracting css code block #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the regexes where expecting always an empty space after .css which is only the case when a hidden attribute is used, it allowed for the info string to come on the next line as the code fence, only allowed ../ but not ./
…. support the hidden attribute
…tyleguide to the new stlymark this will allow in multi-tenant codebases for easier distinguishing between component with the same name
…ithout modification introduce the `raw` option that can be set via params of the code block, front matter of the markdown or config.stlyemark.yaml's `examples` section and won't wrap the markup with `htmlHead`, `bodyHtml` etc from the config when set. Also introduce a new experimental pattern for how the code blocks can be written to be picked up by the stylemark. i.e. `css example-1 hidden` or `html example-1 ./demo/file.html?foo=bar#anchor raw=true hidden` fix #227
feat(pv-stylemark): add info regarding the source of the components s…
…code-blocks--scripts feat(pv-stylemark): add suport for js and html executable code blocks support the hidden attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the regexes where expecting always an empty space after .css which is only the case when a hidden attribute is used, it allowed for the info string to come on the next line as the code fence, only allowed ../ but not ./
== Description ==
== Closes issue(s) ==
== Changes ==
== Affected Packages ==