Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: project addition by vrundraval24 #2216 #2214

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore: project addition by vrundraval24 #2216 #2214

merged 1 commit into from
Oct 9, 2023

Conversation

vrundraval24
Copy link
Contributor

@vrundraval24 vrundraval24 commented Oct 8, 2023 •
edited
Loading

Related Issue

#2216

Description

Screenshots

@vercel
Copy link

vercel bot commented Oct 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Oct 8, 2023 6:53pm

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Oct 8, 2023
github-actions[bot]
github-actions bot reviewed Oct 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @vrundraval24! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal priyankarpal added the no issue number contributor haven't added the issue number label Oct 8, 2023
@priyankarpal
Copy link
Owner

there is no issue number

@vrundraval24
Copy link
Contributor Author

what issue number should i assign i was confused

@priyankarpal
Copy link
Owner

what issue number should i assign i was confused

in open source contribution, we create an issue first and then create a PR after getting assigned.

@vrundraval24 vrundraval24 changed the title chore: project addition by vrundraval24 chore: project addition by vrundraval24 #2216 Oct 8, 2023
@vrundraval24
Copy link
Contributor Author

i have added issue number, please check it

@vrundraval24
Copy link
Contributor Author

Is there any mistake, should i wait for getting assigned to a issue we created and then commit into it??

@priyankarpal priyankarpal removed the no issue number contributor haven't added the issue number label Oct 9, 2023
@priyankarpal priyankarpal merged commit 6128d05 into priyankarpal:main Oct 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@vrundraval24 vrundraval24

Labels
projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrundraval24 @priyankarpal