Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhancing ProjectList.tsx 🪄 ✨ #1972

Merged
merged 2 commits into from
Aug 5, 2023
Merged

refactor: enhancing ProjectList.tsx 🪄 ✨ #1972

merged 2 commits into from
Aug 5, 2023

Conversation

0xabdulkhaliq
Copy link
Contributor

@0xabdulkhaliq 0xabdulkhaliq commented Aug 5, 2023

Related Issue

Close #1970

Description

  • Refactored the ProjectList.tsx Component.
  • Replaced Github icon with External Link icon.
  • Implement hover feature for Cards and UI enhancements.

Demonstrating Video

Capture_2023-08-05-21-28-45.mp4

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 5, 2023 4:16pm

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Aug 5, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @0xabdulkhalid! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this hover effect & add the previous hover border

@priyankarpal priyankarpal added the changes-required changes-required label Aug 5, 2023
@0xabdulkhaliq
Copy link
Contributor Author

The Border could not give visual clue for the User, Who has color disability.

So that i additionally added transform scale to highlight the active element.

Let me know your thoughts @priyankarpal

@priyankarpal
Copy link
Owner

The Border could not give visual clue for the User, Who has color disability.

So that i additionally added transform scale to highlight the active element.

Let me know your thoughts @priyankarpal

just add the previous hover border effect also,I think we don't need to add scale the project card

@0xabdulkhaliq
Copy link
Contributor Author

Successfully reverted 🔁

@0xabdulkhaliq
Copy link
Contributor Author

After merging this PR make sure to check out this issue #1969,

You can assign that to me once you verified it.

@priyankarpal priyankarpal removed the changes-required changes-required label Aug 5, 2023
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Aug 5, 2023
@priyankarpal priyankarpal merged commit 6dd2ba8 into priyankarpal:main Aug 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: add project link to name instead of github logo ⚒️✨
2 participants