Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added star on GitHub image 🌟🚀 #1953

Merged
merged 8 commits into from
Aug 4, 2023
Merged

chore: Added star on GitHub image 🌟🚀 #1953

merged 8 commits into from
Aug 4, 2023

Conversation

Nishitbaria
Copy link
Contributor

Related Issue

Issue : #1810

Description

This PR proposes an improved logo type for the ProjectHunt Project to enhance user engagement and encourage GitHub contributions. The updated logo prominently showcases "Start Contribution" ✨ at the top, followed by "Star on GitHub" 🤝 to prompt users to interact with the repository. Additionally, a dynamic element indicates the total number of stars the project has received, giving users a quick overview of its popularity 🌟.

Key Changes:

  • Responsive Design: The logo is now responsive, ensuring a seamless experience across various screen sizes.

Code Changes:

<div className="github-button p-2 bg-white rounded-lg max-w-[170px] mx-auto">
  <a
    className="github"
    href="https://github.com/priyankarpal/ProjectsHut"
    target="_blank"
    rel="noreferrer"
  >
    <img
      src="https://github.com/priyankarpal/ProjectsHut/assets/88102392/0fa9e8f0-349d-4cc8-8e01-1b6e2c27dbbb"
      alt="Github-Share-Button"
    />
  </a>
</div>

Screenshots

image

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 4, 2023 8:41am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Nishitbaria! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Nishitbaria Nishitbaria changed the title feat: "Start Contribution" with "Star on GitHub" Added Added "Start Contribution" with "Star on GitHub" Feature 🌟🚀 Aug 3, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the image to the right position
image

@priyankarpal priyankarpal added the changes-required changes-required label Aug 3, 2023
@priyankarpal priyankarpal changed the title Added "Start Contribution" with "Star on GitHub" Feature 🌟🚀 chore: Added "Start Contribution" with "Star on GitHub" Feature 🌟🚀 Aug 3, 2023
@priyankarpal priyankarpal added the conflict this branch has conflicts error label Aug 3, 2023
Signed-off-by: Nishitbariya <[email protected]>
@Nishitbaria
Copy link
Contributor Author

PassFab20230804_023536801.mp4

@priyankarpal Please check the changes

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change. align the license & docs heading

Group 2

@Nishitbaria
Copy link
Contributor Author

image
I have fix alignment

@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Aug 4, 2023

image
Also the button is also in alignment

@priyankarpal Check

components/Footer.tsx Outdated Show resolved Hide resolved
components/Footer.tsx Outdated Show resolved Hide resolved
components/Footer.tsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal changed the title chore: Added "Start Contribution" with "Star on GitHub" Feature 🌟🚀 chore: Added star on GitHub image 🌟🚀 Aug 4, 2023
@priyankarpal priyankarpal removed the conflict this branch has conflicts error label Aug 4, 2023
@priyankarpal priyankarpal linked an issue Aug 4, 2023 that may be closed by this pull request
3 tasks
Signed-off-by: Nishitbariya <[email protected]>
Signed-off-by: Nishitbariya <[email protected]>
@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Aug 4, 2023

@priyankarpal Fixed your reviews

@priyankarpal
Copy link
Owner

@Nishitbaria in the future, kindly refrain from using these types of commit messages, as they do not adhere to the valid format. If a user reviews the repository, they might encounter difficulties in understanding the changes made by the contributor.

image

image

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC and removed changes-required changes-required labels Aug 4, 2023
@priyankarpal priyankarpal merged commit 67851e1 into priyankarpal:main Aug 4, 2023
8 checks passed
@Nishitbaria Nishitbaria deleted the #1810 branch August 4, 2023 09:42
@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Aug 4, 2023

@priyankarpal Man I deserve level 2 atleast lol 😂

@priyankarpal
Copy link
Owner

@priyankarpal Man I deserve level 2 atleast lol 😂

I believe that it was a simple change 🙂

@Nishitbaria
Copy link
Contributor Author

@priyankarpal Ohh I see Thanks for Merging 🙃

priyankarpal added a commit that referenced this pull request Aug 5, 2023
* style: aligned  documentation and license in footer (#1954)

* chore: Added `star on GitHub` image 🌟🚀 (#1953)

* feat: "Start Contribution" with "Star on GitHub"  Added

Signed-off-by: Nishitbariya <[email protected]>

* Fix

* Fix Heading Alignment

* Heading Alignment  Fix

* Github Star Button Alignment Fix

Signed-off-by: Nishitbariya <[email protected]>

* fix : use <Link> tag

Signed-off-by: Nishitbariya <[email protected]>

* fix : use <Image> tag

Signed-off-by: Nishitbariya <[email protected]>

---------

Signed-off-by: Nishitbariya <[email protected]>

* chore: added new ML Project by Parul1606 #1938 (#1957)

* chore: added New ML Project

* chore: update project

---------

Co-authored-by: Priyankar Pal <[email protected]>

* chore(deps): bump @types/node from 20.4.6 to 20.4.7 (#1962)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.4.6 to 20.4.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: improve contributing guide (#1956)

* contributing: Updated the Readme

* docs: improve contributing guide

---------

Co-authored-by: Priyankar Pal <[email protected]>

* chore: project addition by pavitrachavda97 #1958 (#1965)

* style: aligned and added responsiveness  documentation and license in… (#1964)

* style: aligned and added responsiveness  documentation and license in footer

* style: makeing the footer responsive

---------

Signed-off-by: Nishitbariya <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sahil Chalke <[email protected]>
Co-authored-by: Nishitbariya <[email protected]>
Co-authored-by: Parul Pandey <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: PAVITRA CHAVDA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: "Start Contribution" with "Star on GitHub" and Total Stars ✨🤝🌟
2 participants