Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the external.invoke (fix #19) #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pierredavidbelanger
Copy link

No description provided.

@pierredavidbelanger pierredavidbelanger changed the title Fixed the external.invoke (Fix #19) Fixed the external.invoke (fix #19) Dec 17, 2022
Erquint added a commit to Erquint/soundsense-rs that referenced this pull request Dec 17, 2022
Erquint added a commit to Erquint/soundsense-rs that referenced this pull request Dec 17, 2022
@Erquint
Copy link

Erquint commented Dec 17, 2022

Seems like maybe you hardcoded it to use Linux files and now it breaks on Windows.

Erquint added a commit to Erquint/soundsense-rs that referenced this pull request Dec 17, 2022
Erquint added a commit to Erquint/soundsense-rs that referenced this pull request Dec 17, 2022
[ci-build]
@pierredavidbelanger
Copy link
Author

I do not understand what is OS specific in my commits.

I only replaced some javascript call using a solution I found here

Ill try something else

@pierredavidbelanger
Copy link
Author

The last commit implements this solution here

@Erquint
Copy link

Erquint commented Dec 18, 2022

Sorry, I'm preoccupied by trying to make a maintained fork of this here repo.
Can't tell I'll be able to go all the way through with it.
But I recreated your PR there in a cruddy way and building with it resulted in window.webkit evaluating to null on every slider drag callback.
Haven't gotten very hands-on with it yet.
I'll pay better attention when I figure out how to improve the build system first.

@pierredavidbelanger
Copy link
Author

did you tried this last commit also ?

Anyways, I feel the portable solution is somewhere in that direction.

I do not have access to an OSX nor Windows environement, so ill leave this PR as is for the maintainer to do whatever he wants with it.

Someone will poke me if they need help I guess.

Meanwhile It works good enough for me to continue my DF game ;)

Copy link

@Erquint Erquint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Wrong repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants