Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 maybe security bug getting ip address #15

Merged
merged 17 commits into from
Oct 21, 2024

Conversation

lukasmatusiewicz
Copy link
Collaborator

@lukasmatusiewicz lukasmatusiewicz commented Oct 8, 2024

This pull request includes several changes to the PrivacyIDEA client and its related provider. The most important changes include modifications to how the client IP is forwarded and improvements to the PrivacyIDEA client instantiation.

PrivacyIDEA client changes:

PrivacyIDEA provider changes:

This pull request also includes several changes primarily focused on simplifying the codebase and removing redundant configurations. The most important changes include the removal of ESLint and Stylelint workflows, updates to the dependabot.yml configuration, and various code style improvements.

Workflow and Configuration Updates:

Code Style Improvements:

These changes help streamline the codebase and remove unnecessary configurations, making the project easier to maintain.

@lukasmatusiewicz lukasmatusiewicz linked an issue Oct 8, 2024 that may be closed by this pull request
@nilsbehlen
Copy link
Member

if you are fine with the lint actions not running properly, you can merge this. the code looks fine.

@lukasmatusiewicz
Copy link
Collaborator Author

the worflows are already fixed, but the updated version will be executed first at the next pr

@lukasmatusiewicz lukasmatusiewicz merged commit 3c92897 into main Oct 21, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Use better method to get IP address
2 participants