-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9 maybe security bug getting ip address #15
Merged
lukasmatusiewicz
merged 17 commits into
main
from
9-maybe-security-bug-getting-ip-address
Oct 21, 2024
Merged
9 maybe security bug getting ip address #15
lukasmatusiewicz
merged 17 commits into
main
from
9-maybe-security-bug-getting-ip-address
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsbehlen
approved these changes
Oct 18, 2024
if you are fine with the lint actions not running properly, you can merge this. the code looks fine. |
the worflows are already fixed, but the updated version will be executed first at the next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
PrivacyIDEA
client and its related provider. The most important changes include modifications to how the client IP is forwarded and improvements to thePrivacyIDEA
client instantiation.PrivacyIDEA client changes:
lib/PIClient/PrivacyIDEA.php
: Changed the type of theforwardClientIP
property frombool
tostring
and updated the logic to forward the client IP if it is not empty. [1] [2] [3]PrivacyIDEA provider changes:
lib/Provider/PrivacyIDEAProvider.php
: Updated thecreatePrivacyIDEAInstance
method to set theforwardClientIP
property only if the client IP is available.lib/Provider/PrivacyIDEAProvider.php
: Modified thegetClientIP
method to return a string and log an error if the client IP cannot be retrieved.This pull request also includes several changes primarily focused on simplifying the codebase and removing redundant configurations. The most important changes include the removal of ESLint and Stylelint workflows, updates to the
dependabot.yml
configuration, and various code style improvements.Workflow and Configuration Updates:
.github/workflows/lint-eslint.yml
: Removed the ESLint workflow configuration..github/workflows/lint-stylelint.yml
: Removed the Stylelint workflow configuration..github/dependabot.yml
: Removed redundant Composer package ecosystems from the Dependabot configuration.Code Style Improvements:
lib/PIClient/PIChallenge.php
: Converted double quotes to single quotes for string literals.lib/PIClient/AuthenticationStatus.php
: Converted constants to use single quotes andpublic
visibility.These changes help streamline the codebase and remove unnecessary configurations, making the project easier to maintain.