Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

183 use kc settings for language selection settings #198

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

lukasmatusiewicz
Copy link
Contributor

This PR includes several changes aimed at improving internationalization support, simplifying code, and enhancing error handling in the privacyidea-authenticator. The most important changes include the removal of hardcoded language strings, the addition of new localized messages, and minor code simplifications.

Internationalization Improvements:

  • Added new localized messages to messages_de.properties, messages_en.properties, messages_fr.properties, and messages_pl.properties files for better support of different languages. [1] [2] [3] [4]
  • Removed hardcoded language strings from Const.java and PrivacyIDEAAuthenticator.java and replaced them with configuration-based messages. [1] [2]

Code Simplifications:

  • Removed unused constants from Const.java to clean up the codebase. [1] [2] [3]
  • Simplified the PrivacyIDEAAuthenticator.java by removing redundant language handling code and improving error message formatting. [1] [2] [3] [4] [5] [6]

Error Handling Enhancements:

  • Improved error logging in JavaScript files by using localized error messages instead of hardcoded strings. [1] [2] [3]

Template Updates:

  • Updated privacyIDEA.ftl template to use localized messages for various UI elements, improving the user experience for non-English speakers.

Miscellaneous:

  • Updated the subproject commit reference in java-client.

@lukasmatusiewicz lukasmatusiewicz linked an issue Nov 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix formatting of auth failure message
1 participant