Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Chinese Traditional Translation #2193

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Enable Chinese Traditional Translation #2193

merged 1 commit into from
Jul 16, 2023

Conversation

dngray
Copy link
Member

@dngray dngray commented Jun 10, 2023 •
edited by jonaharagon
Loading

Changes proposed in this PR:

  • Enable zh-Hant language
  • Add translation notice to footer for it and zh-Hant

@dngray dngray added the l10n Localization label Jun 10, 2023
dngray added a commit that referenced this pull request Jun 10, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
b6ed412
@netlify

This comment was marked as duplicate.

Sign in to view
@netlify

This comment was marked as duplicate.

Sign in to view
@dngray dngray marked this pull request as draft June 10, 2023 19:13
@jonaharagon
Copy link
Member

jonaharagon commented Jun 21, 2023 •
edited
Loading

Just a reminder that the preview is at https://i18n-zhtw.staging.privacyguides.dev/zh-hant/

jonaharagon pushed a commit that referenced this pull request Jun 21, 2023
@dngray @jonaharagon
Enable Chinese Traditional Translation (#2193)
1eeeece
jonaharagon
jonaharagon reviewed Jun 21, 2023
View reviewed changes
netlify.toml Outdated Show resolved Hide resolved
dngray added a commit that referenced this pull request Jun 29, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
e10c80a
dngray added a commit that referenced this pull request Jun 30, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
de048bf
@dngray dngray marked this pull request as ready for review June 30, 2023 20:12
blacklight447
blacklight447 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

dngray added a commit that referenced this pull request Jul 11, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
dd07ae2
dngray added a commit that referenced this pull request Jul 13, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
04ed13b
dngray added a commit that referenced this pull request Jul 13, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
19ba73d
@dngray dngray merged commit 51230eb into main Jul 16, 2023
7 checks passed
@dngray dngray deleted the i18n-zhtw branch July 16, 2023 17:42
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-13/13229/1

dngray added a commit that referenced this pull request Jul 20, 2023
@dngray
Enable Chinese Traditional Translation (#2193)
3f34c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon left review comments

@jxtsai jxtsai jxtsai left review comments

@blacklight447 blacklight447 blacklight447 approved these changes

Assignees
No one assigned
Labels
l10n Localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dngray @jonaharagon @privacyguides-bot @jxtsai @blacklight447