Skip to content

Commit

Permalink
fix: add dummy step in tests job
Browse files Browse the repository at this point in the history
  • Loading branch information
sripwoud committed Jul 2, 2024
1 parent 44e9d2e commit 4a4d5ab
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:

- run: yarn format
tests:
if: needs.changed-files.outputs.any_changed == 'true'
needs: [changed-files, set-matrix, deps, compile]
runs-on: ubuntu-latest
strategy:
Expand All @@ -93,14 +92,18 @@ jobs:

steps:
- uses: actions/checkout@v4
if: needs.changed-files.outputs.any_changed == 'true'
- uses: actions/setup-node@v4
if: needs.changed-files.outputs.any_changed == 'true'
with:
node-version: 20
- uses: actions/cache/restore@v4
if: needs.changed-files.outputs.any_changed == 'true'
with:
path: node_modules
key: ${{ needs.deps.outputs.cache-key }}
- uses: actions/download-artifact@v4
if: needs.changed-files.outputs.any_changed == 'true'
with:
name: all-artifacts
path: packages/
Expand All @@ -119,6 +122,12 @@ jobs:
parallel: true
flag-name: run ${{ join(matrix.*, '-') }}

# this is dummy step was a workaround against the GH limitation of having ci checks to be required even if not run
# see https://github.com/orgs/community/discussions/13690
- if: needs.changed-files.outputs.any_changed != 'true'
name: Skipped
run: echo 'Skipped due to no relevant files changes'

set-matrix:
if: needs.changed-files.outputs.any_changed == 'true'
needs: changed-files
Expand Down

0 comments on commit 4a4d5ab

Please sign in to comment.