Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add release-plz config file #57

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ci: add release-plz config file #57

merged 1 commit into from
Oct 1, 2024

Conversation

sripwoud
Copy link
Member

@sripwoud sripwoud commented Oct 1, 2024

Attempt to address #55 (comment)

Maybe what happened is:

  1. PR merges, release_always is by default true so the release-plz CLI runs
  2. release-pr command (update command AND opening of PR): it tries to update but failed (e.g. no pkg on crates.io and no CHANGELOG file yet, see https://github.com/privacy-scaling-explorations/zk-kit.rust/actions/runs/11124754559/job/30910962049#step:4:230). A PR is opened nonetheless.
  3. release command: runs nonetheless, new crate is published
  4. we merge the release PR created by the previous release GH workflow (previous step)
  5. In the next release workflow run, the release-pr step that includes the update command detects a new commit (the PR merge at step 1) and bumps the version again, creating a new PR too.

A fix could be to set release_always to false.

https://release-plz.ieni.dev/docs/config#the-release_commits-field

diff --git a/.release-plz.toml b/.release-plz.toml
new file mode 100644
index 0000000..d97699d
--- /dev/null
+++ b/.release-plz.toml
@@ -0,0 +1,2 @@
+[workspace]
+release_always = false
@sripwoud sripwoud marked this pull request as ready for review October 1, 2024 13:18
@sripwoud sripwoud requested a review from cedoor as a code owner October 1, 2024 13:18
@sripwoud sripwoud self-assigned this Oct 1, 2024
@sripwoud sripwoud added bug 🐛 Something isn't working devops 🔧 Operations management and dev tools labels Oct 1, 2024
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

@cedoor cedoor merged commit 21de535 into main Oct 1, 2024
5 checks passed
@cedoor cedoor deleted the ci/release-plz branch October 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working devops 🔧 Operations management and dev tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants