Remove fs
from the parameters of Decider::preprocess
#193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current
Decider
trait, thepreprocess
method takesfs
, an instance of theFoldingScheme
trait, as input.However, note that
fs
is created by the prover by runningFoldingScheme::init
with the initial statez_0
. On the other hand,Decider::preprocess
is usually invoked by a trusted party at the beginning (before provers and verifiers are involved), whenz_0
is still unknown.Thus, it makes more sense to remove the
fs
parameter fromDecider::preprocess
. The implementations ofDecider
are updated correspondingly, so that the preprocessing can be done without a concretefs
. Instead, we simply build a dummy decider circuit, during which we only need to provide some parameters that are known before the creation offs
.