Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs from the parameters of Decider::preprocess #193

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

winderica
Copy link
Collaborator

In the current Decider trait, the preprocess method takes fs, an instance of the FoldingScheme trait, as input.

However, note that fs is created by the prover by running FoldingScheme::init with the initial state z_0. On the other hand, Decider::preprocess is usually invoked by a trusted party at the beginning (before provers and verifiers are involved), when z_0 is still unknown.

Thus, it makes more sense to remove the fs parameter from Decider::preprocess. The implementations of Decider are updated correspondingly, so that the preprocessing can be done without a concrete fs. Instead, we simply build a dummy decider circuit, during which we only need to provide some parameters that are known before the creation of fs.

@arnaucube arnaucube added the decider decider/compressed snark label Jan 10, 2025
Copy link
Collaborator

@arnaucube arnaucube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! More clean usage of the Decider now!

@arnaucube arnaucube added this pull request to the merge queue Jan 10, 2025
Merged via the queue into privacy-scaling-explorations:main with commit 31fbe72 Jan 10, 2025
9 checks passed
pmikolajczyk41 pushed a commit to pmikolajczyk41/sonobe that referenced this pull request Jan 10, 2025
…ling-explorations#193)

* `Decider::preprocess` now no longer takes `fs` as input

* Format

* Fix examples

* Fix solidity verifiers

(cherry picked from commit 31fbe72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decider decider/compressed snark
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants