Enable hiding commitments in nova and hypernova #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmpierre
changed the title
arnaucube
reviewed
Jul 18, 2024
dmpierre
force-pushed
the
feat/blinding-commitments
branch
from
3099bef to
19ca029
Compare
dmpierre
force-pushed
the
feat/blinding-commitments
branch
from
19ca029 to
2707b0c
Compare
CPerezz
approved these changes
Jul 22, 2024
arnaucube
reviewed
Jul 25, 2024
arnaucube
reviewed
Jul 25, 2024
arnaucube
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
LGTM! Getting closer to the zk ^^
Just a minor thing in #129 (comment)
arnaucube
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make it possible to specify blinding commitments. It consists in changing how generics are specified for the different structs used with nova and hypernova. We test our changes for pedersen commitments, since blinding factors have been removed from the KZG
commit()method.This PR precedes #127, which adds the ability to generate zk IVC proofs for nova.