Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aa sponsoring #478

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: add aa sponsoring #478

merged 1 commit into from
Nov 11, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Nov 9, 2024

Add account abstraction with Zerodev and Privy

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 1:40pm

@ctrlc03 ctrlc03 self-assigned this Nov 9, 2024
@ctrlc03 ctrlc03 changed the title feat: add aa sponsoring and passkeys feat: add aa sponsoring Nov 9, 2024
0xmad
0xmad reviewed Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just left some comments

packages/interface/src/components/ConnectButton.tsx Show resolved Hide resolved
packages/interface/src/components/JoinButton.tsx Show resolved Hide resolved
packages/interface/src/config.ts Show resolved Hide resolved
packages/interface/src/contexts/Maci.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Maci.tsx Show resolved Hide resolved
packages/interface/src/hooks/useEthersSigner.ts Outdated Show resolved Hide resolved
packages/interface/src/utils/accountAbstraction.ts Outdated Show resolved Hide resolved
packages/interface/src/utils/accountAbstraction.ts Show resolved Hide resolved
packages/interface/src/utils/accountAbstraction.ts Show resolved Hide resolved
@ctrlc03 ctrlc03 requested a review from 0xmad November 11, 2024 05:23
kittybest
kittybest reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! also tested it smoothly on my iphone safari browser, just left a question.

packages/interface/src/providers/index.tsx Show resolved Hide resolved
packages/interface/src/providers/index.tsx Show resolved Hide resolved
kittybest
kittybest approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@kittybest kittybest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For functionality stuff it works well, just need to update the commitlint and fix the lint errors.

@crisgarner
Copy link
Contributor

Thanks! 🙏

@crisgarner crisgarner merged commit 32c7cc5 into feat/devcon-round Nov 11, 2024
14 of 15 checks passed
@crisgarner crisgarner deleted the feat/aa-devcon branch November 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittybest kittybest kittybest approved these changes

@crisgarner crisgarner crisgarner approved these changes

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

Assignees

@ctrlc03 ctrlc03

Labels
None yet
Projects
MACI team sprint board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctrlc03 @crisgarner @kittybest @0xmad