Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve the upload metadata process #443

Merged
merged 1 commit into from
Nov 7, 2024
Merged

feat: improve the upload metadata process #443

merged 1 commit into from
Nov 7, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Nov 6, 2024 •
edited
Loading

Description

  • allow the user to upload metadata through file
  • add an example metadata file
  • instead of asking for 4 dates, just ask the first date, and ask the duration of each period
  • add function description in script
  • update the README.md file --> seems like there's not only instruction about this script needs to be added, open another issue for it.

Related Issues
close #423

@kittybest kittybest self-assigned this Nov 6, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 7:11am

@kittybest kittybest force-pushed the feat/update-upload-metadata-script branch from 70a6915 to 336a104 Compare November 6, 2024 10:41
0xmad
0xmad reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just some suggestions

packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/update-upload-metadata-script branch from 336a104 to 90c0f89 Compare November 7, 2024 06:53
@kittybest kittybest force-pushed the feat/update-upload-metadata-script branch from 90c0f89 to d7b2c64 Compare November 7, 2024 07:07
0xmad
0xmad approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest kittybest merged commit 3ebc5fa into main Nov 7, 2024
17 checks passed
@kittybest kittybest deleted the feat/update-upload-metadata-script branch November 7, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03 ctrlc03 is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI team sprint board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve upload metadata script
2 participants
@kittybest @0xmad