Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add organizer dashboard #276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Aug 23, 2024

Update
Keep this as a separate branch (not merging this), wanna integrate registry stuff on the dev branch and merge it to main first.

Description

  • update Navbar tags displayed
  • add /admin page for organizer dashboard
  • add a temporarily RoundContext for managing the organizer dashboard global UI state
  • UI for deploy contracts
  • UI for deploy rounds
  • UI for display rounds
  • the round info are displayed correctly
  • dark mode for the above UI
  • rearrange pages hierarchy
  • make duplicate components be reusable ui components (such as submit button section, form section, etc.)

@kittybest kittybest self-assigned this Aug 23, 2024
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:03pm

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, there are some comments and why PR is for dev branch?
maci-platform repo has main branch as current changes and tags for stable versions.

packages/interface/src/components/ui/Form.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Outdated Show resolved Hide resolved
Comment on lines +53 to +55
onSubmit={(round) => {
create.mutate(round);
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use arrow functions inside jsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then should we also change the one inside features/applications/components/ApplicationForm.tsx?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see it's used somewhere, it's better to change it because it affects performance.

@kittybest
Copy link
Contributor Author

kittybest commented Sep 24, 2024

@kittybest thanks, there are some comments and why PR is for dev branch? maci-platform repo has main branch as current changes and tags for stable versions.

maybe we should find a better name for it? or are you saying why merge this to dev instead of main? because before was thinking about integrating multi-round and fetching data from subgraph and registry contract on the dev, but now since the registry and other packages are ready, could change the base to main

since currently the only the dev branch containing the multi-round display logic, this branch is based on the multi-round interface. So if we wanna change the branch to be merged to main branch, we need to merge the current dev to main first. How do you think?

@0xmad
Copy link
Collaborator

0xmad commented Sep 30, 2024

@kittybest thanks, there are some comments and why PR is for dev branch? maci-platform repo has main branch as current changes and tags for stable versions.

maybe we should find a better name for it? or are you saying why merge this to dev instead of main? because before was thinking about integrating multi-round and fetching data from subgraph and registry contract on the dev, but now since the registry and other packages are ready, could change the base to main

since currently the only the dev branch containing the multi-round display logic, this branch is based on the multi-round interface. So if we wanna change the branch to be merged to main branch, we need to merge the current dev to main first. How do you think?

I think let's keep dev for now as we discussed before. When we get rid of mock data and integrate new logic with the ui, we can merge dev into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants