-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove some TODOs from codebase #376
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 85.13% 85.14%
=======================================
Files 85 85
Lines 18862 18872 +10
=======================================
+ Hits 16058 16068 +10
Misses 2804 2804 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Description
Related issues
Changes
parallelizecompute_inner_product
utilityColumnMid
inQueryBack
halo2_backend/plonk/permutation
EvaluationDomain::extended_to_coeff
function