Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some TODOs from codebase #376

Merged
merged 7 commits into from
Oct 24, 2024
Merged

chore: remove some TODOs from codebase #376

merged 7 commits into from
Oct 24, 2024

Conversation

guorong009
Copy link

@guorong009 guorong009 commented Oct 18, 2024

Description

  • Take care of some TODOs throughout the repo

Related issues

Changes

  • parallelize compute_inner_product utility
  • use ColumnMid in QueryBack
  • remove renaming in halo2_backend/plonk/permutation
  • refactor the EvaluationDomain::extended_to_coeff function

@guorong009 guorong009 marked this pull request as draft October 18, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (f0a2ebd) to head (ef6f740).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
halo2_backend/src/plonk/evaluation.rs 96.42% 1 Missing ⚠️
halo2_backend/src/plonk/lookup/verifier.rs 80.00% 1 Missing ⚠️
halo2_backend/src/plonk/shuffle/verifier.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   85.13%   85.14%           
=======================================
  Files          85       85           
  Lines       18862    18872   +10     
=======================================
+ Hits        16058    16068   +10     
  Misses       2804     2804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guorong009 guorong009 self-assigned this Oct 21, 2024
@guorong009 guorong009 marked this pull request as ready for review October 21, 2024 09:00
halo2_backend/src/arithmetic.rs Outdated Show resolved Hide resolved
halo2_proofs/tests/compress_selectors.rs Show resolved Hide resolved
Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@guorong009 guorong009 merged commit 433dfbb into main Oct 24, 2024
6 checks passed
@guorong009 guorong009 deleted the gr@remove-todos-0 branch October 24, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants