Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos check in CI #362

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Typos check in CI #362

merged 1 commit into from
Sep 24, 2024

Conversation

adria0
Copy link
Member

@adria0 adria0 commented Aug 8, 2024

Add typo check in CI.

To run it manually:

cargo install typos-cli then typos.
If you are ok with the suggestions, changes can be automatically written with typos -w

note: Seen in https://github.com/scroll-tech/zkevm-circuits/pull/1340/files#diff-3fb2332998c7a34b309e0c52c92bfa1f8e0c429ceec9fddba49834e15d3e0eb6

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (bc857a7) to head (b864585).

Files Patch % Lines
halo2_backend/src/plonk.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          84       84           
  Lines       17750    17751    +1     
=======================================
+ Hits        14670    14671    +1     
  Misses       3080     3080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment. Otherwise LGTM! 👍

typos.toml Show resolved Hide resolved
@adria0 adria0 merged commit 977fc5f into main Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants