forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Preview - historical] Frontend-Backend split #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed255
force-pushed
the
feature/frontend-backend
branch
from
January 5, 2024 10:26
e334d08
to
8813ef7
Compare
CPerezz
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass.
Missing:
- halo2_proofs/src/plonk/prover.rs
- halo2_proofs/src/plonk/shuffle.rs
- halo2_proofs/src/plonk/verifier.rs
- halo2_proofs/src/poly.rs
- halo2_proofs/src/poly/commitment.rs
- halo2_proofs/tests/frontend_backend_split.rs
- halo2_proofs/tests/plonk_api.rs
So far this is an amazing work! I'm super excited! Happy to have forward discussions over improvements and paths to follow!
ed255
force-pushed
the
feature/frontend-backend
branch
from
January 15, 2024 13:15
6b8ffaa
to
d350e72
Compare
This was referenced Jan 16, 2024
ed255
changed the title
[Preview] Frontend-Backend split
[Preview - historical] Frontend-Backend split
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a historical preview of the Frontend-Backend halo2 split
This PR is not yet ready for merge, but it's ready for reviewing and discussing the approach. See this issue for more details: #239
Note that many names of functions and structs contain
v2
,Backend
and other suffixes. This is temporary.What has been done in this PR:
Gate
type is added which holds a single constraint (polynomial identity). The simplified ConstraintSystem still has a list of gates.Error::Other
that contains a string used to report fine grained errors. This is not required by the frontend-backend split but I believe improves a lot the ux, and I believe this was needed for a long time (specially to avoid having opaqueSynthesis
errors during witness generation).What's missing:
Polynomial<Assigned<F>>
from the frontend-backend interface, in favor of justVec<F>
.Benchmarks
To reproduce the benchmarks you need to build the tests in release with
cargo test --release build
and then figure out the path of the generated binary in../target/release/deps/frontend_backend_split-...
. Thetime
program is GNU time, and the max memory used is reported underMaximum resident set size (kbytes)
.These results have the following parameters (commit
84954577c98cf2822c24ce44f64d2962f3579f4a
)Legacy
Fe-Be split