patch: include shuffles in transcript, even when empty (#348)

* feat: include "shuffles" in "PinnedConstraintSystem::fmt" * chore: fix the "plonk_api" test
privacy-scaling-explorations · Jun 6, 2024 · d52ebca · d52ebca
1 parent b4d1c4c
commit d52ebca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/halo2_backend/src/plonk/circuit.rs b/halo2_backend/src/plonk/circuit.rs
@@ -275,11 +275,9 @@ impl<'a, F: Field> std::fmt::Debug for PinnedConstraintSystem<'a, F> {
             .field("instance_queries", self.instance_queries)
             .field("fixed_queries", self.fixed_queries)
             .field("permutation", self.permutation)
-            .field("lookups", self.lookups);
-        if !self.shuffles.is_empty() {
-            debug_struct.field("shuffles", self.shuffles);
-        }
-        debug_struct.field("minimum_degree", self.minimum_degree);
+            .field("lookups", self.lookups)
+            .field("shuffles", self.shuffles)
+            .field("minimum_degree", self.minimum_degree);
         debug_struct.finish()
     }
 }

diff --git a/halo2_proofs/tests/plonk_api.rs b/halo2_proofs/tests/plonk_api.rs
@@ -1112,6 +1112,7 @@ fn plonk_api() {
                 ],
             },
         ],
+        shuffles: [],
         minimum_degree: None,
     },
     fixed_commitments: [