Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifyProof function as view as it does not modify storage #20

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

dibi91
Copy link
Contributor

@dibi91 dibi91 commented Sep 26, 2024

As discussed on #18
Noticed bug about rust last version during tests and examples
Close #18

@han0110
Copy link
Collaborator

han0110 commented Sep 30, 2024

Could you also help createrust-toolchain file and fix the version to 1.77.0? I think it'd resolve the CI issue for now.

@dibi91
Copy link
Contributor Author

dibi91 commented Sep 30, 2024

Done!

@dibi91
Copy link
Contributor Author

dibi91 commented Oct 1, 2024

Now it fails because of svm-rs that requires at least 1.8.0 rust version. I can specify in step Install solc to use the [email protected] that requires rust version greater than 1.7.0 svm-rs cargo.toml.

I made a test on a different branch link

Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@han0110 han0110 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into privacy-scaling-explorations:main with commit 9e99730 Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solidity verifyProof function as view
2 participants