[SelectPanel] Don't clear selection if input field doesn't exist (#3186)

primer · Nov 7, 2024 · 4d46a3a · 4d46a3a
1 parent 8e15cd4
commit 4d46a3a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/silent-wasps-peel.md b/.changeset/silent-wasps-peel.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+[SelectPanel] Don't clear selection if input field doesn't exist
diff --git a/app/components/primer/alpha/select_panel_element.ts b/app/components/primer/alpha/select_panel_element.ts
@@ -465,10 +465,13 @@ export class SelectPanelElement extends HTMLElement {
       this.dialog.removeAttribute('data-ready')
       this.invokerElement?.setAttribute('aria-expanded', 'false')
       // When we close the dialog, clear the filter input
-      const fireSearchEvent = this.filterInputTextField.value.length > 0
-      this.filterInputTextField.value = ''
-      if (fireSearchEvent) {
-        this.filterInputTextField.dispatchEvent(new Event('input'))
+
+      if (this.filterInputTextField) {
+        const fireSearchEvent = this.filterInputTextField.value.length > 0
+        this.filterInputTextField.value = ''
+        if (fireSearchEvent) {
+          this.filterInputTextField.dispatchEvent(new Event('input'))
+        }
       }
 
       this.dispatchEvent(