Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(FormControl): update FormControl to use CSS Modules behind flag #5578

Merged
merged 4 commits into from
Jan 21, 2025
Merged

refactor(FormControl): update FormControl to use CSS Modules behind flag #5578

merged 4 commits into from
Jan 21, 2025

Conversation

hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 21, 2025 •
edited
Loading

Changelog

New

Changed

  • Update FormControl and shared internal components to use form control behind feature flag

Removed

Rollout strategy

  • Minor release

@hussam-i-am hussam-i-am self-assigned this Jan 21, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9aad703

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5578 January 21, 2025 18:40 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.55 KB (+0.3% 🔺)
packages/react/dist/browser.umd.js 104.97 KB (+0.4% 🔺)

@hussam-i-am hussam-i-am changed the title Revert "Revert "refactor(FormControl): update FormControl to use CSS Modules behind flag"" refactor(FormControl): update FormControl to use CSS Modules behind flag Jan 21, 2025
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 21, 2025
@hussam-i-am
update InputLabel
eb95b25
@hussam-i-am
Merge branch 'main' of https://github.com/primer/react into revert-54…
f10bd7f 
…94-revert-5438-refactor/update-form-control-to-css-modules-3
@github-actions github-actions bot temporarily deployed to storybook-preview-5578 January 21, 2025 20:09 Inactive
@hussam-i-am hussam-i-am marked this pull request as ready for review January 21, 2025 20:25
@hussam-i-am hussam-i-am requested a review from a team as a code owner January 21, 2025 20:25
@hussam-i-am hussam-i-am requested a review from jonrohan January 21, 2025 20:25
@hussam-i-am
Copy link
Contributor Author

@jonrohan @francinelucca Regarding the regressions, looks like the internal components within InputLabel were not using toggleStyledComponent to conditionally add the styling which were causing labels to be bolded.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358641

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

jonrohan
jonrohan approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

francinelucca
francinelucca approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Can probably get CI to green by following Path to Green , I don't think these failures are related to this PR, ping me if any questions!

@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 88b8533 Jan 21, 2025
43 checks passed
@hussam-i-am hussam-i-am deleted the revert-5494-revert-5438-refactor/update-form-control-to-css-modules-3 branch January 21, 2025 23:19
@primer primer bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussam-i-am @jonrohan @francinelucca