Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ACH public API, sample UI and Android wrapper #216

Merged
merged 44 commits into from
Sep 17, 2024
Merged

feat: ACH public API, sample UI and Android wrapper #216

merged 44 commits into from
Sep 17, 2024

Conversation

FlaviuExtPrimer
Copy link
Contributor

@FlaviuExtPrimer FlaviuExtPrimer commented May 28, 2024 •
edited
Loading

@FlaviuExtPrimer
chore: implement StripeAchUserDetailsCollectableDataRN
099d71f
@FlaviuExtPrimer
chore: implement StripeAchUserDetailsStep
d486ed1
@FlaviuExtPrimer
chore: implement PrimerRNHeadlessUniversalCheckoutStripeAchUserDetail…
5b321ad 
…sComponent
@FlaviuExtPrimer
chore: implement StripeAchMandateManager
fbc8576
@FlaviuExtPrimer
chore: refactor StripeAchMandateManager
36cbd16
@FlaviuExtPrimer
chore: convert TokenizationStartedRN into object
53355c9
@FlaviuExtPrimer
chore: align ACH step and collectable naming with Android SDK
57a9e88
@FlaviuExtPrimer
chore: implement callback support for AchAdditionalInfo
5f5e3a8
@FlaviuExtPrimer
chore: implement AchManager
ebf027d
@FlaviuExtPrimer
chore: fix properties not being serialized
c18dad8
@FlaviuExtPrimer
chore: implement vault manager support for ACH
cc4dd65
@FlaviuExtPrimer
chore: implement HeadlessCheckoutAchScreen
1456823
@FlaviuExtPrimer
chore: fix build issues caused by migration to compileSdk 34
7704a10
@FlaviuExtPrimer
chore: remove react-native-picker/picker
d5e6986
@FlaviuExtPrimer
chore: update yarn.lock
c2a0996
@FlaviuExtPrimer
chore: rename ACH component providing function to be generic
681c06c
@FlaviuExtPrimer
chore: use generic name for ACH mandate manager
10e5e11
@FlaviuExtPrimer
chore: fix ACH imports
39d5da7
@FlaviuExtPrimer
chore: fix ACH onValidationError handling
d58492a
@FlaviuExtPrimer
Copy link
Contributor Author

TODO

  • Update Stripe SDK wrapper to the latest version
  • Update Primer SDK to the latest version that contains ACH API

@FlaviuExtPrimer
Merge remote-tracking branch 'origin/master' into feat/ACC-3019-ACC-3…
c63b019 
…020-ACC-3022/ACH-react-native-android-and-shared-code

# Conflicts:
#	packages/sdk/android/build.gradle
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Appetize iOS link: https://appetize.io/app/2xkvthh7z3mrgyqe67myzkvvz4

semirp
semirp reviewed Aug 1, 2024
View reviewed changes
packages/example/src/screens/AchMandateAlert.tsx Outdated Show resolved Hide resolved
packages/example/src/screens/HeadlessCheckoutStripeAchScreen.tsx Outdated Show resolved Hide resolved
packages/sdk/android/build.gradle Outdated Show resolved Hide resolved
packages/sdk/android/gradle.properties Outdated Show resolved Hide resolved
...k/android/src/main/java/com/primerioreactnative/PrimerRNHeadlessUniversalCheckoutListener.kt Outdated Show resolved Hide resolved
...ive/components/manager/ach/PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent.kt Outdated Show resolved Hide resolved
...ive/components/manager/ach/PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent.kt Outdated Show resolved Hide resolved
...ive/components/manager/ach/PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent.kt Outdated Show resolved Hide resolved
...ges/sdk/android/src/main/java/com/primerioreactnative/datamodels/ach/AchUserDetailsStepRN.kt Outdated Show resolved Hide resolved
packages/sdk/src/HeadlessUniversalCheckout/Managers/PaymentMethodManagers/AchManager.ts Outdated Show resolved Hide resolved
@FlaviuExtPrimer
Copy link
Contributor Author

Just a few points.

  1. I don't see any unit tests. Is that something that we ignore for Rn?
  2. I see new interfaces, do we need to update RN documentation?

Otherwise it looks good, I am still learning reactnative though.

Kudos for the video!

  1. Indeed, we're not focusing on unit tests in RN right now.
  2. SDK docs are provided by this PR.

@FlaviuExtPrimer
Copy link
Contributor Author

This is ready for review again, all change requests have been handled. cc @semirp.

@github-actions GitHub Actions
Copy link

Appetize Android link: https://appetize.io/app/jjper9un2gzrzp55htr6bjuty0

@FlaviuExtPrimer FlaviuExtPrimer marked this pull request as ready for review September 16, 2024 13:12
@FlaviuExtPrimer FlaviuExtPrimer requested a review from a team as a code owner September 16, 2024 13:12
@jnewc jnewc merged commit 9e74135 into master Sep 17, 2024
9 of 10 checks passed
@jnewc jnewc deleted the feat/ACC-3019-ACC-3020-ACC-3022/ACH-react-native-android-and-shared-code branch September 17, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semirp semirp semirp approved these changes

@jnewc jnewc jnewc approved these changes

@NQuinn27 NQuinn27 Awaiting requested review from NQuinn27

@gt-prime gt-prime Awaiting requested review from gt-prime

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlaviuExtPrimer @jnewc @semirp @gt-prime