Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: collect coverage from platforms and upload to Sonar #213

Merged
merged 42 commits into from
May 17, 2024

Conversation

semirp
Copy link
Contributor

@semirp semirp commented May 15, 2024

We want to perform Sonar scan and also collect coverage from all relevant sources. Therefore, we have:

  • created a coverage script for TS files
  • created a coverage script for Kotlin files
  • created a coverage script for iOS files

We have created a new workflow that runs three separate jobs:

  • runs unit tests for RN and uploads coverage file
  • runs unit tests for Android and uploads coverage file
  • runs unit tests for iOS and uploads coverage file

All of the files are then downloaded and correct coverage paths are assigned to sonar-project.properties.

@primer-io primer-io deleted a comment from sonarcloud bot May 15, 2024
Copy link

Appetize Android link: https://appetize.io/app/w14mykr0j8grrftm9z9ba6d860

Copy link

github-actions bot commented May 15, 2024

Appetize iOS link: https://appetize.io/app/epphkthhzddx3z4bcabzersw5u

@semirp semirp changed the title ci: collect coverage from TS files and upload to Sonar ci: collect coverage from platforms and upload to Sonar May 16, 2024
Copy link
Contributor

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Gemfile Outdated Show resolved Hide resolved
Copy link
Contributor

@NQuinn27 NQuinn27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

@semirp semirp merged commit 30c7851 into bn/add-jest-test-suite May 17, 2024
10 checks passed
@semirp semirp deleted the ci/add-code-coverage branch May 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants