Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: map RN theme colors to iOS and Android theme models #204

Merged
merged 18 commits into from
May 29, 2024
Merged

feat: map RN theme colors to iOS and Android theme models #204

merged 18 commits into from
May 29, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Apr 10, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Appetize Android link: https://appetize.io/app/dbdn63n0xwdftxvrmgt8cdvd74

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Appetize iOS link: https://appetize.io/app/l6j64qiplsog7n4cywiba2buq4

@jnewc
Copy link
Contributor Author

jnewc commented Apr 11, 2024

Needs master merge after 2.21.0 release

@jnewc jnewc changed the title Map RN theme colors to iOS theme models Map RN theme colors to iOS and Android theme models Apr 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@semirp semirp changed the title Map RN theme colors to iOS and Android theme models feat: map RN theme colors to iOS and Android theme models May 29, 2024
semirp
semirp approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@semirp semirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@semirp semirp requested a review from NQuinn27 May 29, 2024 09:02
@jnewc jnewc merged commit 061c320 into master May 29, 2024
9 of 10 checks passed
@jnewc jnewc deleted the jn/ios-theming branch May 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlaviuExtPrimer FlaviuExtPrimer FlaviuExtPrimer approved these changes

@semirp semirp semirp approved these changes

@NQuinn27 NQuinn27 Awaiting requested review from NQuinn27

@borisprimer borisprimer Awaiting requested review from borisprimer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jnewc @semirp @FlaviuExtPrimer @BorisNikolic @NQuinn27 @vasi-twks