Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent dismissal of Drop-in card form while a payment is active #1031

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

borisprimer
Copy link
Contributor

@borisprimer borisprimer self-assigned this Oct 21, 2024
@borisprimer borisprimer requested a review from a team as a code owner October 21, 2024 11:52
Copy link
Contributor

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏

Generated by 🚫 Danger Swift against 6b652fa

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@@ -328,7 +328,58 @@ class CardFormPaymentMethodTokenizationViewModel: PaymentMethodTokenizationViewM
})
}

super.start()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the face of it I dont like introducing this repetition for the sake of one line difference. Understand a more elegant solution might not be simple, but were there any other approaches considered?

Would there be any way we could take self.uiManager.primerRootViewController?.enableUserInteraction(true) out of the super implementation, and inject it/execute it from the contexts it is needed.

Also begs the question: is self.uiManager.primerRootViewController?.enableUserInteraction(true) actually required in the super method? Will other flows break without this? @BorisNikolic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticketed here

@NQuinn27 NQuinn27 merged commit f127f64 into master Oct 23, 2024
13 of 14 checks passed
@NQuinn27 NQuinn27 deleted the fix/ACC-4038 branch October 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants