Skip to content

Commit

Permalink
🚫 Removed option to choose custom bullet color
Browse files Browse the repository at this point in the history
When option to choose a custom color for bullets is available, Style Settings go wonk and doesn't understand stuff so it ignores CSS and snippets and everything. This is despite having correct syntax. Fixes #92
  • Loading branch information
ceciliamay committed Mar 17, 2022
1 parent edeb49a commit 0a8ff07
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 29 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Primary was crafted with a "perfect fundamentals first, nail other features late
- Dataview by Michael Brenan
- Supercharged Links by mdelobelle
- Style Settings by mgmeyers — through this plugin, you can change fonts, colors, and get access to features!
- Map View by esm

If you'd like to see what plugins I'm planning to support next, check out the roadmap linked above.

Expand Down
31 changes: 17 additions & 14 deletions obsidian.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion obsidian.css.map

Large diffs are not rendered by default.

22 changes: 8 additions & 14 deletions scss/80_plugins-community/_style-settings__options.scss
Original file line number Diff line number Diff line change
Expand Up @@ -474,28 +474,22 @@ settings:
level: 2
collapsed: true
-
id: md-color-bullet
id: md-bullet-color
title: Preset Bullet Color
type: variable-select
default: 'var(--md-color-text-faint)'
description: Select your preferred bullet color (applied to all bullets, ordered and unordered)
type: class-select
allowEmpty: false
default: md-bullet-color-faint
options:
-
label: Like Body Text
value: 'var(--md-color-text)'
value: md-bullet-color-normal
-
label: Muted
value: 'var(--md-color-text-muted)'
value: md-bullet-color-muted
-
label: Faint
value: 'var(--md-color-text-faint)'
-
id: md-color-bullet
title: Custom Bullet Color
type: variable-themed-color
format: hsl
opacity: true
default-light: 'hsl(34, 37%, 70%)'
default-dark: 'hsl(34, 24%, 30%)'
value: md-bullet-color-faint
-
id: note-embeds
title: 📍 Embeds
Expand Down
23 changes: 23 additions & 0 deletions scss/80_plugins-community/_style-settings__preferences.scss
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,29 @@ body.header-size {
}

/*────────── note ──────────*/
/* bullet color */
.md-bullet-color-muted {
&.theme-light,
&.theme-dark {
& span.cm-formatting.cm-formatting-list,
& span.list-bullet,
& li::marker {
color: var(--md-color-text-muted);
}
}
}

.md-bullet-color-normal {
&.theme-light,
&.theme-dark {
& span.cm-formatting.cm-formatting-list,
& span.list-bullet,
& li::marker {
color: ar(--md-color-text);
}
}
}

/* center embeds */
body.center-embeds {
& img {
Expand Down

0 comments on commit 0a8ff07

Please sign in to comment.