Skip to content

Commit

Permalink
✨ Add SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions
Browse files Browse the repository at this point in the history
Fixes #80
  • Loading branch information
dpi committed Jun 4, 2024
1 parent 92ee35a commit bdbcc79
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 8 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ function doesAThing(array $data): int {
#### SlevomatCodingStandard.Functions.StaticClosure
#### SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure
#### SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses
#### SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions

PHPStorm can be configured with Editor -> General -> Auto Import: _Function_: `Prefer FQN`

#### SlevomatCodingStandard.TypeHints.DeclareStrictTypes
#### SlevomatCodingStandard.TypeHints.ReturnTypeHint
#### SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing
Expand Down
16 changes: 8 additions & 8 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@
"homepage": "https://github.com/previousnext/coding-standard",
"keywords": ["drupal", "phpcs"],
"require": {
"php": "^8.0",
"php": "^8.1",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"drupal/coder": "^8.3.24",
"slevomat/coding-standard": "^8.13.2",
"squizlabs/php_codesniffer": "^3.7.1"
"slevomat/coding-standard": "^8.15.0",
"squizlabs/php_codesniffer": "^3.10.1"
},
"require-dev": {
"phpstan/extension-installer": "^1.2",
"phpstan/phpstan": "^1.9.4",
"phpstan/phpstan-deprecation-rules": "^1.1.1",
"phpstan/phpstan-strict-rules": "^1.4.4",
"phpunit/phpunit": "^9.5.27"
"phpstan/extension-installer": "^1.3.1",
"phpstan/phpstan": "^1.11.3",
"phpstan/phpstan-deprecation-rules": "^1.2.0",
"phpstan/phpstan-strict-rules": "^1.6.0",
"phpunit/phpunit": "^9.6.19"
},
"license": "MIT",
"autoload": {
Expand Down
29 changes: 29 additions & 0 deletions tests/Sniffs/FullyQualifiedGlobalFunctionsTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

declare(strict_types=1);

namespace PreviousNext\CodingStandard\Tests\Sniffs;

use SlevomatCodingStandard\Sniffs\Namespaces\FullyQualifiedGlobalFunctionsSniff;

/**
* @covers \SlevomatCodingStandard\Sniffs\Namespaces\FullyQualifiedGlobalFunctionsSniff
*/
final class FullyQualifiedGlobalFunctionsTest extends Base {

public function testNoError(): void {
$report = self::checkFile(__DIR__ . '/fixtures/FullyQualifiedGlobalFunctionsNoError.php');
self::assertNoSniffErrorInFile($report);
}

public function testError(): void {
$report = self::checkFile(__DIR__ . '/fixtures/FullyQualifiedGlobalFunctionsError.php');
self::assertSame(1, $report->getErrorCount());
self::assertSniffError($report, 7, FullyQualifiedGlobalFunctionsSniff::CODE_NON_FULLY_QUALIFIED);
}

protected static function getSniffName(): string {
return 'SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions';
}

}
7 changes: 7 additions & 0 deletions tests/Sniffs/fixtures/FullyQualifiedGlobalFunctionsError.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

declare(strict_types=1);

namespace Somewhere;

echo strlen('Foo bar');
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

declare(strict_types=1);

namespace Somewhere;

echo \strlen('Foo bar');

0 comments on commit bdbcc79

Please sign in to comment.