Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite transpose_tiles to be in-place #475

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Rewrite transpose_tiles to be in-place #475

merged 1 commit into from
Oct 7, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Oct 6, 2024 •
edited
Loading

Follow-up to #470. Makes the transpose_tiles function more efficient (no memory allocation, and no redundant assignment operations), with identical outputs.

for f in `find gfx -name '*.pic'`; do x=${f%.pic}; tools/pkmncompress -u $x.pic $x.tmp; cmp $x.tmp $x.2bpp; rm -f $x.tmp; done

@Rangi42 Rangi42 requested a review from dannye October 6, 2024 01:45
@Rangi42 Rangi42 force-pushed the transpose branch 2 times, most recently from d9c7654 to c377cfe Compare October 6, 2024 02:03
@Rangi42 Rangi42 merged commit a6715ef into pret:master Oct 7, 2024
1 check passed
@Rangi42 Rangi42 deleted the transpose branch October 7, 2024 16:04
PokefanMarcel pushed a commit to PokefanMarcel/yumepokered that referenced this pull request Oct 18, 2024
@Rangi42 @PokefanMarcel
Rewrite transpose_tiles to be in-place (pret#475)
e484395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannye dannye Awaiting requested review from dannye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rangi42