Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document communication_information #172

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Conversation

adrienntindall
Copy link
Collaborator

Almost done but wanna open early since it's quite a few files, want to make sure all the names are in the plat convention and such

@adrienntindall adrienntindall marked this pull request as ready for review April 1, 2024 03:56
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused mostly on names/consistency here, will leave more detailed feedback as the PR progresses.

include/communication_information.h Outdated Show resolved Hide resolved
include/communication_system.h Outdated Show resolved Hide resolved
include/communication_system.h Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
src/communication_information.c Outdated Show resolved Hide resolved
src/communication_information.c Outdated Show resolved Hide resolved
src/communication_information.c Outdated Show resolved Hide resolved
src/communication_information.c Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
include/communication_information.h Outdated Show resolved Hide resolved
include/communication_system.h Outdated Show resolved Hide resolved
src/communication_information.c Outdated Show resolved Hide resolved
@lhearachel lhearachel merged commit 8185c23 into pret:main Apr 1, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants