Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished documenting PoketchData #170

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

TrainerRiley
Copy link
Contributor

No description provided.

include/poketch_data.h Outdated Show resolved Hide resolved
include/poketch_data.h Outdated Show resolved Hide resolved
include/poketch_data.h Outdated Show resolved Hide resolved
@TrainerRiley
Copy link
Contributor Author

TrainerRiley commented Mar 30, 2024

Alright, switched those 4 enum values to defines and renamed the function parameters cbt6 mentioned.

@TrainerRiley TrainerRiley requested a review from cbt6 March 30, 2024 06:29
@TrainerRiley
Copy link
Contributor Author

Okay, I've removed a lot of redundant comments + improved some function names for clarity.

include/poketch_data.h Outdated Show resolved Hide resolved
include/poketch_data.h Outdated Show resolved Hide resolved
src/poketch_data.c Outdated Show resolved Hide resolved
src/poketch_data.c Outdated Show resolved Hide resolved
include/poketch_data.h Outdated Show resolved Hide resolved
include/poketch_data.h Outdated Show resolved Hide resolved
@TrainerRiley
Copy link
Contributor Author

Addressed lhea's comments

Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge pending OK build

@lhearachel lhearachel merged commit 6010f54 into pret:main Apr 1, 2024
1 check passed
@TrainerRiley TrainerRiley deleted the finish_poketch_data branch April 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants