Generate enum-based battle constants at build-time #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
commented
Jan 7, 2024
Comment on lines
-106
to
-128
| enum { | ||
| OVERWORLD_WEATHER_CLEAR = 0, | ||
| OVERWORLD_WEATHER_CLOUDY, | ||
| OVERWORLD_WEATHER_RAINING, | ||
| OVERWORLD_WEATHER_HEAVY_RAIN, | ||
| OVERWORLD_WEATHER_THUNDERSTORM, | ||
| OVERWORLD_WEATHER_SNOWING, | ||
| OVERWORLD_WEATHER_HEAVY_SNOW, | ||
| OVERWORLD_WEATHER_BLIZZARD, | ||
| OVERWORLD_WEATHER_CLEAR_8, | ||
| OVERWORLD_WEATHER_SLOW_ASHFALL, | ||
| OVERWORLD_WEATHER_SANDSTORM, | ||
| OVERWORLD_WEATHER_HAILING, | ||
| OVERWORLD_WEATHER_SPIRITS, | ||
| OVERWORLD_WEATHER_CLEAR_13, | ||
| OVERWORLD_WEATHER_FOG, | ||
| OVERWORLD_WEATHER_DEEP_FOG, | ||
| OVERWORLD_WEATHER_DARK_FLASH, | ||
|
|
||
| // these are only for the Battle Frontier | ||
| OVERWORLD_WEATHER_HARSH_SUN = 1001, | ||
| OVERWORLD_WEATHER_TRICK_ROOM, | ||
| }; |
There was a problem hiding this comment.
I moved these to #define syntax, since there is a break in values outside the usual step-increments.
mid-kid
reviewed
Jan 7, 2024
| @@ -18,3 +18,9 @@ if not nitrogfx_exe.found() | |||
| subproject('nitrogfx', default_options: 'native=true') | |||
| nitrogfx_exe = find_program('nitrogfx', native: true) | |||
| endif | |||
|
|
|||
| constgen_py = find_program('constgen_py', native: true, required: false) | |||
There was a problem hiding this comment.
Can't you use the fallback: parameter? Granted, that's a new meson feature I think.
There was a problem hiding this comment.
This isn't really a fallback candidate, since it's not a different name. We're expecting to find it under this name.
|
My only complaint is that nobody is gonna be able to find the source of truth through neither their IDE nor a simple Either:
Or both, preferably both. |
I decided both was worthwhile, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of a subproject that I wrote for generating constants files from a basic manifest schema. The goal here is to support having a single source of truth for such definitions that can be utilized by both the compiler and a direct assembler invocation for building data files (which we will need for battle scripts). The assembler does not support reading
enumdefinitions out-of-the-box, so these definitions would need to either be:#definesyntax, which is less-than-ideal for self-documentation of function signatures