Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define field script opcode constants #2005

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

rayrobdod
Copy link
Contributor

Description

Also replace the magic number opcodes in field script command macros with these new constants

Discord contact info

yoshord

Replace the magic number opcodes in field script command macros with
these new constants
Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea here and I think it will reduce mistakes, I just have a few comments on style :)

data/script_cmd_table.inc Outdated Show resolved Hide resolved
asm/macros/event.inc Show resolved Hide resolved
data/script_cmd_table.inc Outdated Show resolved Hide resolved
data/script_cmd_table.inc Outdated Show resolved Hide resolved
@mrgriffin mrgriffin merged commit b5b0ffd into pret:master Jan 17, 2025
1 check passed
@rayrobdod rayrobdod deleted the scr_op_constants branch January 18, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants