feat(presto-client): add get catalog, schema, table & column utility methods #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeramirezamora
changed the title
ManfredA
reviewed
Jan 17, 2024
ManfredA
reviewed
Jan 17, 2024
alonsovb
commented
Jan 17, 2024
There was a problem hiding this comment.
I moved all private methods to the bottom, and left the public ones alphabetically sorted at the top
yhwang
reviewed
Jan 18, 2024
presto-client/README.md
Outdated
|
|
||
| ### Get Columns | ||
|
|
||
| The `getColumns` method retrieves a list of columns filtered for the given catalog and optional schema and table filters. It accepts an object with `catalog`, and optional `schema` and `table` parameters. |
There was a problem hiding this comment.
It would be good if you could mention the Column data type here.
yhwang
reviewed
Jan 18, 2024
presto-client/README.md
Outdated
|
|
||
| ### Get Tables | ||
|
|
||
| The `getTables` method retrieves a list of tables filtered by the given catalog and, optionally, the schema. It accepts an object containing `catalog` and optional `schema` parameters. |
There was a problem hiding this comment.
also the Table data type here. Thanks!
There was a problem hiding this comment.
done for both cases 👍
yhwang
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #13 and #14
getCatalogsgetSchemasgetTablesgetColumns